Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validate_template_version_patch method to use parent_service_template_name instead of parent_resource_id #3825

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jan 11, 2024

Fixes #3824

This pull request refactors the validate_template_version_patch method in order to use the parent_service_template_name instead of the parent_resource_id. This was preventing user resource upgrades from working.

Copy link

github-actions bot commented Jan 11, 2024

Unit Test Results

588 tests   588 ✅  7s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit ea9c03d.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Jan 12, 2024

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7499784309 (with refid 33e9bbbf)

(in response to this comment from @marrobi)

1 similar comment
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7499784309 (with refid 33e9bbbf)

(in response to this comment from @marrobi)

@SvenAelterman
Copy link
Collaborator

@marrobi Can you confirm the right issue is linked? I don't see the relationship between Key Vault secrets restore and this PR.

@marrobi
Copy link
Member Author

marrobi commented Jan 12, 2024

@marrobi Can you confirm the right issue is linked? I don't see the relationship between Key Vault secrets restore and this PR.

It is now, sorry.

@marrobi
Copy link
Member Author

marrobi commented Jan 12, 2024

/test-force-approve

Passed: https://github.com/microsoft/AzureTRE/actions/runs/7499784309

@marrobi marrobi enabled auto-merge (squash) January 12, 2024 16:17
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ea9c03d)

(in response to this comment from @marrobi)

Copy link
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass

@marrobi marrobi merged commit 00db0ee into microsoft:main Jan 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot upgrade user reources
2 participants